lkml.org 
[lkml]   [2008]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86 iommu: remove unneeded parenthesis
On Tue, Aug 19, 2008 at 02:13:55AM +0200, Jiri Kosina wrote:
> The parenthesis in __iommu_queue_command() are not needed when assigning into 'target' variable.
>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
>
> diff --git a/arch/x86/kernel/amd_iommu.c b/arch/x86/kernel/amd_iommu.c
> index de39e1f..69b4d06 100644
> --- a/arch/x86/kernel/amd_iommu.c
> +++ b/arch/x86/kernel/amd_iommu.c
> @@ -65,7 +65,7 @@ static int __iommu_queue_command(struct amd_iommu *iommu, struct iommu_cmd *cmd)
> u8 *target;
>
> tail = readl(iommu->mmio_base + MMIO_CMD_TAIL_OFFSET);
> - target = (iommu->cmd_buf + tail);
> + target = iommu->cmd_buf + tail;
> memcpy_toio(target, cmd, sizeof(*cmd));
> tail = (tail + sizeof(*cmd)) % iommu->cmd_buf_size;
> head = readl(iommu->mmio_base + MMIO_CMD_HEAD_OFFSET);
>

True, thanks Jiri.

Acked-by: Joerg Roedel <joerg.roedel@amd.com>

--
| AMD Saxony Limited Liability Company & Co. KG
Operating | Wilschdorfer Landstr. 101, 01109 Dresden, Germany
System | Register Court Dresden: HRA 4896
Research | General Partner authorized to represent:
Center | AMD Saxony LLC (Wilmington, Delaware, US)
| General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy



\
 
 \ /
  Last update: 2008-08-19 09:57    [W:0.036 / U:75.548 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site