Messages in this thread | | | Date | Tue, 19 Aug 2008 22:58:08 +0100 | From | Alan Cox <> | Subject | Re: [PATCH 06/10] ldisc n_tty: export all N_TTY ldisc methods. |
| |
On Tue, 19 Aug 2008 23:50:08 +0200 Rodolfo Giometti <giometti@linux.it> wrote:
> Signed-off-by: Rodolfo Giometti <giometti@linux.it> > --- > drivers/char/n_tty.c | 54 +++++++++++++++++++++++++++++-------------------- > include/linux/tty.h | 16 ++++++++++++++ > 2 files changed, 48 insertions(+), 22 deletions(-)
Renames are really not part of the same change set but very sensible so no objection. EXPORT_SYMBOL_GPL please - pps is (with permission) sticking its nose into the innards of n_tty. Those are not good general interfaces however.
With the small changes noted I'm happy for the tty stuff to go upstream.
| |