lkml.org 
[lkml]   [2008]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] rtc: rtc-ds1374: fix 'no irq' case handling
From
Date
>>>>> "Anton" == Anton Vorontsov <avorontsov@ru.mvista.com> writes:

Anton> On a PowerPC board with ds1374 RTC I'm getting this error while
Anton> RTC tries to probe:

Anton> rtc-ds1374 0-0068: unable to request IRQ

Anton> This happens because I2C probing code (drivers/of/of_i2c.c) is
Anton> specifying IRQ0 for 'no irq' case, which is correct.

Anton> The driver handles this incorrectly, though. This patch fixes it.

Great, I was just about to send a similar patch. Another advantage of
using 0 for 'no irq' is for I2C_BOARD_INFO(). With that you can simply
not assign anything to .irq instead of having to set it to -1.

Acked-by: Peter Korsgaard <jacmet@sunsite.dk>

--
Bye, Peter Korsgaard


\
 
 \ /
  Last update: 2008-08-19 22:05    [W:0.042 / U:35.300 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site