lkml.org 
[lkml]   [2008]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] KVM_GUEST: use the right parameter type on kvm_release_pt() (was Re: i386 allmodconfig in linux-next)
On Tue, Aug 19, 2008 at 04:41:41PM +0300, Avi Kivity wrote:
> Andrew Morton wrote:
>> arch/x86/kernel/kvm.c: In function 'paravirt_ops_setup':
>> arch/x86/kernel/kvm.c:233: warning: assignment from incompatible pointer type
>> arch/x86/kernel/kvm.c:234: warning: assignment from incompatible pointer type
>> arch/x86/kernel/kvm.c:235: warning: assignment from incompatible pointer type
>>
>
> Eduardo, this is your
>
>> commit fa24f8e67c189b8b904c8a34f12e6dae9c14dbba
>> Author: Eduardo Habkost <ehabkost@redhat.com>
>> Date: Wed Jul 30 18:32:27 2008 -0300
>>
>> x86, paravirt_ops: use unsigned long instead of u32 for alloc_p*()
>> pfn args
>
> Please compile-test (and run-test?) paravirt_ops changes with
> CONFIG_KVM_GUEST and CONFIG_KVM_CLOCK enabled. Thanks.
>

Oops, sorry. I've grepped for 'alloc_p*' and didn't notice KVM was using
release_p*. I've checked for binary code changes with all paravirt guest
options enabled, but missed the compiler warnings. Fix below.

---
From: Eduardo Habkost <ehabkost@redhat.com>
Subject: [PATCH] KVM_GUEST: Use the right parameter type on kvm_release_pt()

This fixes the following compiler warnings, that were introduced by me
on commit fa24f8e67c189b8b904c8a34f12e6dae9c14dbba.

arch/x86/kernel/kvm.c: In function 'paravirt_ops_setup':
arch/x86/kernel/kvm.c:233: warning: assignment from incompatible pointer type
arch/x86/kernel/kvm.c:234: warning: assignment from incompatible pointer type
arch/x86/kernel/kvm.c:235: warning: assignment from incompatible pointer type

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
arch/x86/kernel/kvm.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c
index 8b7a3cf..478bca9 100644
--- a/arch/x86/kernel/kvm.c
+++ b/arch/x86/kernel/kvm.c
@@ -178,7 +178,7 @@ static void kvm_flush_tlb(void)
kvm_deferred_mmu_op(&ftlb, sizeof ftlb);
}

-static void kvm_release_pt(u32 pfn)
+static void kvm_release_pt(unsigned long pfn)
{
struct kvm_mmu_op_release_pt rpt = {
.header.op = KVM_MMU_OP_RELEASE_PT,
--
1.5.5.GIT
--
Eduardo


\
 
 \ /
  Last update: 2008-08-19 21:21    [W:0.043 / U:11.188 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site