lkml.org 
[lkml]   [2008]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] add hrtimer_sleep_ns helper function
On Wed, Aug 06, 2008 at 03:08:19PM -0400, Josef Bacik wrote:
> -static int __sched do_nanosleep(struct hrtimer_sleeper *t, enum hrtimer_mode mode)
> +static int __sched do_nanosleep(struct hrtimer_sleeper *t, enum hrtimer_mode mode,
> + int interruptible)
> {
> hrtimer_init_sleeper(t, current);
>
> do {
> - set_current_state(TASK_INTERRUPTIBLE);
> + set_current_state(interruptible ? TASK_INTERRUPTIBLE :
> + TASK_UNINTERRUPTIBLE);

I don't see any users (in this patch or the next) of people wanting
uninterruptible nanosleeps. We shouldn't be introducing new
TASK_UNINTERRUPTIBLE users, but instead using TASK_KILLABLE if the user
really can't cope with signals in a sensible manner.

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."


\
 
 \ /
  Last update: 2008-08-19 21:17    [W:0.059 / U:0.984 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site