Messages in this thread | | | Date | Tue, 19 Aug 2008 08:23:17 +0200 | Subject | Re: [PATCH 0/5] ide debugging macros | From | Borislav Petkov <> |
| |
On Mon, Aug 18, 2008 at 11:08:38PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Sunday 17 August 2008, Borislav Petkov wrote: > > Hi Bart, > > > > here's something i've been wanting to do for a long time: debugging macros. The > > reason for it is that i got tired of adding debug printk's everytime i'm testing > > something so here we go. > > > > The debugging macro is similar to the old ones but is one for all drivers > > (currently only ide-floppy), is nice on branch prediction and is controlled by a > > drive->debug_mask switch which is a module parameter and as such can be set at > > module load time, of course. I've been thinking of adding also a sysfs attribute > > too but can't seem to find quite the justification for it so no sysfs for now :) > > if you look closely you should already find it :) > > [ module parameters are exported through sysfs and it uses 0644 mask ]
Aah, i get it now, it's /sys/bus/ide/drivers/ide-floppy/module/parameters/debug_mask. However, it'd be better if it were /sys/bus/ide/drivers/ide-floppy/debug_mask. Probably a symlink or a true /sysfs parameter? Maybe later :).
-- Regards/Gruss, Boris.
| |