lkml.org 
[lkml]   [2008]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: ftrace introduces instability into kernel 2.6.27(-rc2,-rc3)


On Mon, 18 Aug 2008, Mathieu Desnoyers wrote:

> * Steven Rostedt (rostedt@goodmis.org) wrote:
> >
> > On Tue, 19 Aug 2008, Benjamin Herrenschmidt wrote:
> >
> > >
> > > > Hmm, this was originally copied from x86, where we did a cmpxchg, but that
> > > > is probably not needed since all of this is done in kstop_machine. Also,
> > > > only the "get" is needed. If we don't fault there, we wont fault on the
> > > > put (unless we have permissions wrong, and that would be a bug).
> > >
> > > Would it ? How do we make sure the kernel text is mapped writeable ?
> >
> > We map it writeable if FTRACE is enabled.
> >
>
> Argh. See text_poke(). It's there exactly for this purpose on x86.
>

OK, I just tried text_poke and it unfortunately fails. The problem is that
it requires that the text you are changing is aligned and fits on one
page. We have no control over that.

-- Steve



\
 
 \ /
  Last update: 2008-08-19 18:51    [W:0.132 / U:47.552 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site