lkml.org 
[lkml]   [2008]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] binfmt_misc.c: avoid potential kernel stack overflow
Andrew Morton wrote:
> On Mon, 18 Aug 2008 18:09:23 +0400
> Pavel Emelyanov <xemul@openvz.org> wrote:
>
>> (Put lkml in Cc. The original message is beyond)
>>
>> Oops! My fault. The problem is that in case of modularized binfmt,
>> the appropriate binary handler gets registered _before_ the script
>> one and sets the misc_bang flag even too early.
>>
>> Thus when we launch a script the load_misc_binary sets this bang,
>> then returns error, since the binary is actually a script, then the
>> load_script_binary successfully loads the script, then it loads the
>> misc binary again, which exits with the -ENOEXEC error due to bang
>> set.
>>
>> This patch helped my box, what about yours?
>>
>> diff --git a/fs/binfmt_misc.c b/fs/binfmt_misc.c
>> index 7562053..8d7e88e 100644
>> --- a/fs/binfmt_misc.c
>> +++ b/fs/binfmt_misc.c
>> @@ -120,8 +120,6 @@ static int load_misc_binary(struct linux_binprm *bprm, struct pt_regs *regs)
>> if (bprm->misc_bang)
>> goto _ret;
>>
>> - bprm->misc_bang = 1;
>> -
>> /* to keep locking time low, we copy the interpreter string */
>> read_lock(&entries_lock);
>> fmt = check_file(bprm);
>> @@ -199,6 +197,8 @@ static int load_misc_binary(struct linux_binprm *bprm, struct pt_regs *regs)
>> if (retval < 0)
>> goto _error;
>>
>> + bprm->misc_bang = 1;
>> +
>> retval = search_binary_handler (bprm, regs);
>> if (retval < 0)
>> goto _error;
>
> <scrabble, hunt>
>
> I put together the below description. It has no signed-off-by: (yet).

Well, sorry for that, I just wanted to get the Kirill's approval of the
fix, while testing other things myself. I sent the properly formatted
patch later. So can you, please, pick the comment and/or subject from
that one (which is a bit less messy, I think)?

> Has this been sufficiently well tested and checked to be in a merge-ready
> state?

I have checked different combinations, so I believe it has.

> Thanks.

Thanks,
Pavel


\
 
 \ /
  Last update: 2008-08-19 12:11    [W:0.049 / U:14.088 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site