lkml.org 
[lkml]   [2008]   [Aug]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [alsa-devel] [PATCH] duplicate SNDRV_PCM_FMTBIT_S{16,24}_BE
At Tue, 19 Aug 2008 08:15:05 +0200 (CEST),
Johannes Berg wrote:
>
> roel kluin wrote:
> > untested, is it correct?
>
> not a clue, do you know how long ago that was? :)
> does the driver check endianness anywhere?

AFAIK snd-aoa supports only bit-endian formats (at least in
sound/aoa/soundbus/i2sbus-pcm.c), so this addition makes little
sense.

Better to drop the duplicated words there.


thanks,

Takashi

> > duplicate SNDRV_PCM_FMTBIT_S{16,24}_BE
> >
> > Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> > ---
> > diff --git a/sound/aoa/codecs/snd-aoa-codec-tas.c
> > b/sound/aoa/codecs/snd-aoa-codec-tas.c
> > index 7a16a33..c922505 100644
> > --- a/sound/aoa/codecs/snd-aoa-codec-tas.c
> > +++ b/sound/aoa/codecs/snd-aoa-codec-tas.c
> > @@ -654,15 +654,15 @@ static struct snd_kcontrol_new bass_control = {
> > static struct transfer_info tas_transfers[] = {
> > {
> > /* input */
> > - .formats = SNDRV_PCM_FMTBIT_S16_BE | SNDRV_PCM_FMTBIT_S16_BE |
> > - SNDRV_PCM_FMTBIT_S24_BE | SNDRV_PCM_FMTBIT_S24_BE,
> > + .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S16_BE |
> > + SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S24_BE,
> > .rates = SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 |
> > SNDRV_PCM_RATE_48000,
> > .transfer_in = 1,
> > },
> > {
> > /* output */
> > - .formats = SNDRV_PCM_FMTBIT_S16_BE | SNDRV_PCM_FMTBIT_S16_BE |
> > - SNDRV_PCM_FMTBIT_S24_BE | SNDRV_PCM_FMTBIT_S24_BE,
> > + .formats = SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S16_BE |
> > + SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S24_BE,
> > .rates = SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 |
> > SNDRV_PCM_RATE_48000,
> > .transfer_in = 0,
> > },
> >
> >
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>


\
 
 \ /
  Last update: 2008-08-19 11:55    [W:0.056 / U:4.576 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site