Messages in this thread | | | Date | Mon, 18 Aug 2008 16:28:30 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH -tip] rcuclassic: fix compiler warning |
| |
On Mon, Aug 18, 2008 at 02:39:21PM -0700, Hiroshi Shimamoto wrote: > From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > > CC kernel/rcuclassic.o > kernel/rcuclassic.c: In function 'rcu_init_percpu_data': > kernel/rcuclassic.c:705: warning: comparison of distinct pointer types lacks a cast > kernel/rcuclassic.c:713: warning: comparison of distinct pointer types lacks a cast > > flags should be unsigned long.
You beat me to it!
Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> > --- > kernel/rcuclassic.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/rcuclassic.c b/kernel/rcuclassic.c > index fb1f1cc..86ff6d6 100644 > --- a/kernel/rcuclassic.c > +++ b/kernel/rcuclassic.c > @@ -700,7 +700,7 @@ void rcu_check_callbacks(int cpu, int user) > static void rcu_init_percpu_data(int cpu, struct rcu_ctrlblk *rcp, > struct rcu_data *rdp) > { > - long flags; > + unsigned long flags; > > spin_lock_irqsave(&rcp->lock, flags); > memset(rdp, 0, sizeof(*rdp)); > -- > 1.5.6 >
| |