lkml.org 
[lkml]   [2008]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] POWERPC: duplicate test of MACIO_FLAG_SCCB_ON
From
Date
On Mon, 2008-08-18 at 18:34 -0400, roel kluin wrote:
> untested, is it correct?

Your patch is correct. The bug is quite harmless thankfully :-)

Ben.

> arch/powerpc/include/asm/pmac_feature.h:359:
> #define MACIO_FLAG_SCCA_ON 0x00000001
> #define MACIO_FLAG_SCCB_ON 0x00000002
> ---
> duplicate test of MACIO_FLAG_SCCB_ON
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
> ---
> diff --git a/arch/powerpc/platforms/powermac/feature.c b/arch/powerpc/platforms/powermac/feature.c
> index 5169ecc..e6c0040 100644
> --- a/arch/powerpc/platforms/powermac/feature.c
> +++ b/arch/powerpc/platforms/powermac/feature.c
> @@ -2677,7 +2677,7 @@ static void __init probe_one_macio(const char *name, const char *compat, int typ
> macio_chips[i].of_node = node;
> macio_chips[i].type = type;
> macio_chips[i].base = base;
> - macio_chips[i].flags = MACIO_FLAG_SCCB_ON | MACIO_FLAG_SCCB_ON;
> + macio_chips[i].flags = MACIO_FLAG_SCCA_ON | MACIO_FLAG_SCCB_ON;
> macio_chips[i].name = macio_names[type];
> revp = of_get_property(node, "revision-id", NULL);
> if (revp)



\
 
 \ /
  Last update: 2008-08-18 23:45    [W:0.103 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site