lkml.org 
[lkml]   [2008]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[patch 21/49] acer-wmi: Fix wireless and bluetooth on early AMW0 v2 laptops
    2.6.25-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Carlos Corbacho <carlos@strangeworlds.co.uk>

    commit 5c742b45dd5fbbb6cf74d3378341704f4b23c5e8 upstream

    In the old acer_acpi, I discovered that on some of the newer AMW0 laptops
    that supported the WMID methods, they don't work properly for setting the
    wireless and bluetooth values.

    So for the AMW0 V2 laptops, we want to use both the 'old' AMW0 and the
    'new' WMID methods for setting wireless & bluetooth to guarantee we always
    enable it.

    This was fixed in acer_acpi some time ago, but I forgot to port the patch
    over to acer-wmi when it was merged.

    (Without this patch, early AMW0 V2 laptops such as the Aspire 5040 won't
    work with acer-wmi, where-as they did with the old acer_acpi).

    AK: fix compilation

    Signed-off-by: Carlos Corbacho <carlos@strangeworlds.co.uk>
    Signed-off-by: Andi Kleen <ak@linux.intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/misc/acer-wmi.c | 19 +++++++++++++++++++
    1 file changed, 19 insertions(+)

    --- a/drivers/misc/acer-wmi.c
    +++ b/drivers/misc/acer-wmi.c
    @@ -742,11 +742,30 @@ static acpi_status get_u32(u32 *value, u

    static acpi_status set_u32(u32 value, u32 cap)
    {
    + acpi_status status;
    +
    if (interface->capability & cap) {
    switch (interface->type) {
    case ACER_AMW0:
    return AMW0_set_u32(value, cap, interface);
    case ACER_AMW0_V2:
    + if (cap == ACER_CAP_MAILLED)
    + return AMW0_set_u32(value, cap, interface);
    +
    + /*
    + * On some models, some WMID methods don't toggle
    + * properly. For those cases, we want to run the AMW0
    + * method afterwards to be certain we've really toggled
    + * the device state.
    + */
    + if (cap == ACER_CAP_WIRELESS ||
    + cap == ACER_CAP_BLUETOOTH) {
    + status = WMID_set_u32(value, cap, interface);
    + if (ACPI_FAILURE(status))
    + return status;
    +
    + return AMW0_set_u32(value, cap, interface);
    + }
    case ACER_WMID:
    return WMID_set_u32(value, cap, interface);
    default:
    --


    \
     
     \ /
      Last update: 2008-08-18 21:37    [W:4.149 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site