lkml.org 
[lkml]   [2008]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] ata: Add support for Long Logical Sectors and Long Physical Sectors
    > +	static const char command_sect_size[256] = {
    > + [ ATA_CMD_CFA_TRANSLATE_SECTOR ] = DEVICE,

    Should be a bit array so we can do a single fast test_bit()

    > + if (size == UNKNOWN && printk_ratelimit())
    > + printk("Unknown ata cmd %d, assuming 512 byte sector size\n",
    > + command);

    or two bits ;)


    Rest looks ok. I'll probably send a follow up patch to make most pata
    drivers return "no" to anything but 512 until we can test them with real
    devices.

    Alan


    \
     
     \ /
      Last update: 2008-08-18 20:27    [W:0.030 / U:0.056 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site