Messages in this thread | | | Date | Mon, 18 Aug 2008 19:06:29 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] ata: Add support for Long Logical Sectors and Long Physical Sectors |
| |
> + static const char command_sect_size[256] = { > + [ ATA_CMD_CFA_TRANSLATE_SECTOR ] = DEVICE,
Should be a bit array so we can do a single fast test_bit()
> + if (size == UNKNOWN && printk_ratelimit()) > + printk("Unknown ata cmd %d, assuming 512 byte sector size\n", > + command);
or two bits ;)
Rest looks ok. I'll probably send a follow up patch to make most pata drivers return "no" to anything but 512 until we can test them with real devices.
Alan
| |