Messages in this thread | | | From | Cyrill Gorcunov <> | Subject | [PATCH 0/15] apic: unification series 5 | Date | Mon, 18 Aug 2008 20:45:48 +0400 |
| |
This series is over
commit d5e629a6f88137fb77c4cc857be5ea7c3f27110d Author: Yinghai Lu <yhlu.kernel@gmail.com> Date: Sun Aug 17 21:12:27 2008 -0700
x86: apic - unify lapic_resume - fix
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> Signed-off-by: Ingo Molnar <mingo@elte.hu>
Please review - any comments are quite welcome!
Mostly #ifdef added, code rearrangement - nothing serious (except new bugs have been brought in :-)
So I think the most simple/basic unification is done. Now unif. process will be harder since it will require for much detailed code review - for example smp_spurious_interrupt which uses different call frames on 32/64 bit modes and will require some wrapping I think.
With this series 32bit code compilation warns:
arch/x86/kernel/apic_32.c: In function ‘end_local_APIC_setup’: arch/x86/kernel/apic_32.c:1165: warning: ISO C90 forbids mixed declarations and code arch/x86/kernel/apic_32.c: In function ‘disconnect_bsp_APIC’: arch/x86/kernel/apic_32.c:1446: warning: ISO C90 forbids mixed declarations and code cyrill@lenovo linux-2.6.git $
So parenthesis will be needed to eliminate them... but I think it could be too ugly... need some time to think. So patches 8/15 and 10/15 sould be not applied for now - just review them. Thanks for patience!
- Cyrill - -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |