Messages in this thread | | | Subject | Re: [stable] Fixing rt2500pci [PATCH] | Date | Sun, 17 Aug 2008 10:58:56 +0200 | From | Ivo van Doorn <> |
| |
On Sunday 17 August 2008, Greg KH wrote: > On Tue, Aug 12, 2008 at 12:01:26PM +0200, Ivo van Doorn wrote: > > On Thursday 31 July 2008, Peter Chubb wrote: > > > > > > In kernel version 2.6.26-rc9 my wireless LAN card worked; but in the > > > released 2.6.26, my RaLink rt2500 card wouldn't associate. > > > > > > Git-bisect led me to this patch: > > > > > > 61486e0f68d1f8966c09b734566a187d42d65c54 > > > rt2x00: Remove ieee80211_tx_control argument from write_tx_desc() > > > > > > I believe that there is a problem with that patch --- it > > > (inadvertantly) removes an extra line of code, that used to set the > > > DATABYTE_COUNT field. > > > > > > This patch reinstates that line, and with it my card works again. > > > > > > Signed-off-by: Peter Chubb <peterc@gelato.unsw.edu.au> > > > Acked-by: Ivo van Doorn <IvDoorn@gmail.com> > > > > [stable@kernel.org added to CC] > > > > The 2.6.27 version of the patch has already been pushed upstream, > > this one is for 2.6.26-stable since this fixes a regression introduced after 2.6.25. > > Are you sure? Looking at 2.6.26, the code in that function looks like > it is properly setting the TXD_W0_DATABYTE_COUNT, field. > > If it's really a problem, can you send stable@kernel.org a patch that > applies to 2.6.26.2?
Hmm, that is weird, that line is indeed present, which means that the commit which was responsible for the breakage wasn't in 2.6.26. I guess peter tested a git checkout from after 2.6.26 or something. :S
Ivo
| |