Messages in this thread | | | Date | Sat, 16 Aug 2008 12:01:02 +0200 | From | Mikael Pettersson <> | Subject | Re: [PATCH 1/3] ATA Kconfig cleanup: hide ATA_SFF and add SATA/PATA menu items |
| |
Grant Coady writes: > > From: Grant Coady <gcoady.lk@gmail.com> > > ATA Kconfig cleanup 1/3: Hide ATA_SFF, add PATA and SATA driver menu > enable items, and add dependency on the enabled PATA/SATA lines to > all the ATA drivers except the PATA_PLATFORM items.
...
> @@ -147,7 +166,7 @@ > > config SATA_PROMISE > tristate "Promise SATA TX2/TX4 support" > - depends on PCI > + depends on ATA_SFF_SATA && PCI > help > This option enables support for Promise Serial ATA TX2/TX4.
As I told you last time this came up, sata_promise drives both sata and pata ports. One board has 4 pata ports, a couple have two sata ports and one pata port, and a couple have 4 sata ports. It's the same ata engine, however.
So at least give sata_promise the same treatment you gave ata_piix:
> @@ -104,7 +123,7 @@ > > config ATA_PIIX > tristate "Intel ESB, ICH, PIIX3, PIIX4 PATA/SATA support" > - depends on PCI > + depends on (ATA_SFF_SATA || ATA_SFF_PATA) && PCI > help > This option enables support for ICH5/6/7/8 Serial ATA > and support for PATA on the Intel ESB/ICH/PIIX3/PIIX4 series > @@ -114,7 +133,7 @@
I suspect sata_via will want this too.
/Mikael
| |