Messages in this thread Patch in this message |  | | From | "H. Peter Anvin" <> | | Subject | RE: [PATCH] pci: change msi-x vector to 32bit | | Date | Fri, 15 Aug 2008 20:26:33 -0700 |
| |
The 28 bits aren't enough, are they: we need domain as well (and surely we can have more than 16 domains?)
-hpa
-- Sent from my mobile phone (pardon any lack of formatting)
-----Original Message----- From: Yinghai Lu <yhlu.kernel@gmail.com> Sent: Friday, August 15, 2008 19:36 To: Jesse Barnes <jbarnes@virtuousgeek.org>; James Bottomley <James.Bottomley@hansenpartnership.com>; Ingo Molnar <mingo@elte.hu>; Thomas Gleixner <tglx@linutronix.de>; H. Peter Anvin <hpa@zytor.com>; Eric W. Biederman <ebiederm@xmission.com>; Andrew Morton <akpm@linux-foundation.org> Cc: linux-kernel@vger.kernel.org; Yinghai Lu <yhlu.kernel@gmail.com>; Andrew Vasquez <andrew.vasquez@qlogic.com> Subject: [PATCH] pci: change msi-x vector to 32bit
we are using 28bit pci (bus/dev/fn + 12 bits) as irq number, so the cache for irq number should be 32 bit too.
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com> Cc: Andrew Vasquez <andrew.vasquez@qlogic.com>
--- drivers/scsi/qla2xxx/qla_def.h | 2 +- include/linux/pci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
Index: linux-2.6/drivers/scsi/qla2xxx/qla_def.h =================================================================== --- linux-2.6.orig/drivers/scsi/qla2xxx/qla_def.h +++ linux-2.6/drivers/scsi/qla2xxx/qla_def.h @@ -2109,7 +2109,7 @@ struct scsi_qla_host; struct qla_msix_entry { int have_irq; - uint16_t msix_vector; + uint32_t msix_vector; uint16_t msix_entry; }; Index: linux-2.6/include/linux/pci.h =================================================================== --- linux-2.6.orig/include/linux/pci.h +++ linux-2.6/include/linux/pci.h @@ -730,7 +730,7 @@ enum pci_dma_burst_strategy { }; struct msix_entry { - u16 vector; /* kernel uses to write allocated vector */ + u32 vector; /* kernel uses to write allocated vector */ u16 entry; /* driver uses to specify entry, OS writes */ };
|  |