Messages in this thread | | | Date | Fri, 15 Aug 2008 20:35:38 +0400 | From | Cyrill Gorcunov <> | Subject | Re: [patch 8/8] x86: apic - unify init_bsp_APIC |
| |
[Maciej W. Rozycki - Fri, Aug 15, 2008 at 04:31:57PM +0100] | On Fri, 15 Aug 2008, Cyrill Gorcunov wrote: | | > Since lapic_is_integrated is just eliminated on 64bit I thought | > it's better to have smooth code flow as much as possible. By 'smooth' | > I mean to not use #ifdef until there is no chance to escape from. | | Of course! | | > And Maciej - you're so right - if someone will take a look on the | > apic_64.c code now he will be quite wondered what lapic_is_integrated | > is doing in 64bit code. | | I just questioned the purpose of reformatting the comment. I see no | problem with lapic_is_integrated() appearing in 64-bit code -- if someone | cannot figure out why it would appear there, they better practised some | thinking at home before coming back. We have plenty of places with such | constructs that expand to literals for some configurations all over our | tree anyway. | | Maciej |
Ah... it was about comment, now it's clear what you meant (for me).
- Cyrill -
| |