Messages in this thread | | | Date | Fri, 15 Aug 2008 08:57:14 -0600 | From | Jonathan Corbet <> | Subject | Re: [PATCH] msr: Fix NULL pointer deref due to msr_open on nonexistent CPUs |
| |
On Thu, 14 Aug 2008 15:43:33 -0700 "Darrick J. Wong" <djwong@us.ibm.com> wrote:
> msr_open tests for someone trying to open a device for a nonexistent > CPU. However, the function always returns 0, not ret like it should, > hence userspace can BUG the kernel trivially. This bug was > introduced by the cdev lock_kernel pushdown patch last May.
> - return 0; > + return ret;
Oops, that was pretty silly. Apologies for the screwup.
jon
| |