lkml.org 
[lkml]   [2008]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: fix /proc/meminfo DirectMap
On Fri, Aug 15, 2008 at 01:58:32PM +0100, Hugh Dickins wrote:
> Do we actually want these DirectMap lines in the x86 /proc/meminfo?
> I can see they're interesting to CPA developers and TLB optimizers,
> but they don't fit its usual "where has all my memory gone?" usage.

It was intended for the "why is my computer going slower" usage.

> If they are to stay, here are some fixes.
>
> 1. On x86_32 without PAE, they're not 2M but 4M pages: no need to
> mess with the internal enum, but show the right name to users.
>
> 2. Many machines can never show anything but 0 for DirectMap1G,
> so suppress that line unless direct_gbpages are really enabled.

I made them unconditional to minimize the risk of some dumb
parser not being able to deal with them. Longer term there
will be more and more machines that support them.

Admittedly that's not a very strong argument.

-Andi


\
 
 \ /
  Last update: 2008-08-15 15:17    [from the cache]
©2003-2011 Jasper Spaans