Messages in this thread | | | Date | Fri, 15 Aug 2008 13:51:48 +0200 | From | Ingo Molnar <> | Subject | Re: [patch 8/8] x86: apic - unify init_bsp_APIC |
| |
* Cyrill Gorcunov <gorcunov@gmail.com> wrote:
> On Thu, Aug 14, 2008 at 11:44 PM, Maciej W. Rozycki > <macro@linux-mips.org> wrote: > > On Thu, 1 Jan 1970, Cyrill Gorcunov wrote: > > > >> @@ -962,7 +962,8 @@ void __init init_bsp_APIC(void) > >> */ > >> apic_write(APIC_LVT0, APIC_DM_EXTINT); > >> value = APIC_DM_NMI; > >> - if (!lapic_is_integrated()) /* 82489DX */ > >> + /* discrete on 82489DX */ > >> + if (!lapic_is_integrated()) > >> value |= APIC_LVT_LEVEL_TRIGGER; > >> apic_write(APIC_LVT1, value); > >> } > > > > Please elaborate. > > > > Maciej > > > > Hi Maciej, > > don't really understand what do you mean. [...]
i suspect the question might have been: 'why this change'.
If that was the question, the answer would be: to unify apic_32.c and apic_64.c we first use tiny little changes to bring the two files in sync. Presumably, each such change is a NOP or at least very safe - and clearly bisectable in the worst-case.
In this case, something that only makes sense on 32-bit has been added over to the 64-bit side. The resulting apic.c file will have to have legacy code as well - but hopefully not too much.
Cyrill, i've applied your series to tip/x86/apic. (i have fixed the timestamps) Please address Maciej's feedback as well, in subsequent patches.
Ingo
| |