lkml.org 
[lkml]   [2008]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 3/6] ftrace: enable mcount recording for modules
    Rusty Russell wrote:
    > On Friday 15 August 2008 05:45:09 Steven Rostedt wrote:
    >
    >> This patch enables the loading of the __mcount_section of modules and
    >> changing all the callers of mcount into nops.
    >>
    > ...
    >
    >> + if (mcountindex) {
    >> + void *mseg = (void *)sechdrs[mcountindex].sh_addr;
    >> + ftrace_init_module(mseg, mseg + sechdrs[mcountindex].sh_size);
    >>
    >
    > You don't actually need the if. The size of section 0 is 0.
    >

    Thanks,

    But I find the if is a bit more clear. It may confuse code reviewers if
    we expect them to know that sechdrs[0].sh_size is zero. This isn't a hot
    path.

    -- Steve




    \
     
     \ /
      Last update: 2008-08-15 01:45    [W:0.070 / U:29.092 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site