lkml.org 
[lkml]   [2008]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC][PATCH] netconsole: avoid deadlock on printk from driver code
From
From: Pekka J Enberg <penberg@cs.helsinki.fi>
Date: Thu, 14 Aug 2008 16:44:32 +0300 (EEST)

> @@ -598,6 +598,7 @@
>
> spinlock_t lock;
> spinlock_t rx_lock;
> + spinlock_t tx_lock;
>
> chip_t chipset;
> u32 rx_config;

Why create a special purpose lock when the generic networking
already is taking a lock for you to proect the TX path?

Furthermore, as I just described in another reply, netpoll
already knows that it might need to trylock() attempt on this
lock in order to avoid the very deadlocks this thread is
about.


\
 
 \ /
  Last update: 2008-08-15 00:17    [from the cache]
©2003-2011 Jasper Spaans