Messages in this thread | | | From | Johannes Weiner <> | Subject | Re: [PATCH 2.6.27-rc3 26/29] mdb: export task_curr | Date | Thu, 14 Aug 2008 17:05:47 +0200 |
| |
jmerkey@wolfmountaingroup.com writes:
>> On Thu, Aug 14, 2008 at 9:14 AM, <jmerkey@wolfmountaingroup.com> wrote: >>> export the task_curr function to the module based kernel debugger to >>> enable >>> process back tracing and state display. >>> >>> Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) >>> >>> --- a/kernel/sched.c 2008-08-13 14:22:32.000000000 -0600 >>> +++ b/kernel/sched.c 2008-08-13 11:56:03.000000000 -0600 >>> @@ -1736,6 +1736,9 @@ >>> { >>> return cpu_curr(task_cpu(p)) == p; >>> } >>> +#if defined(CONFIG_MDB_MODULE) >>> +EXPORT_SYMBOL_GPL(task_curr); >>> +#endif >> >> We usually don't export symbols conditionally, especially in core kernel >> code. >> > > Well,then please suggest how a kernel debugger can be module based and still > be able to get this information some other way that's generic and minimal > impact.
EXPORT_SYMBOL_GPL(task_curr);
Without the #if's. Just export it.
Hannes
| |