lkml.org 
[lkml]   [2008]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] UBIFS: correct orphan deletion order
    Date
    From: Adrian Hunter <ext-adrian.hunter@nokia.com>

    The debug function that checks orphans, does so using the
    TNC mutex. That means it will not see a correct picture
    if the inode is removed from the orphan tree before it is
    removed from TNC.

    Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
    ---
    fs/ubifs/journal.c | 3 ++-
    1 files changed, 2 insertions(+), 1 deletions(-)

    diff --git a/fs/ubifs/journal.c b/fs/ubifs/journal.c
    index 25de6fd..acdae00 100644
    --- a/fs/ubifs/journal.c
    +++ b/fs/ubifs/journal.c
    @@ -871,10 +871,11 @@ int ubifs_jnl_delete_inode(struct ubifs_info *c, const struct inode *inode)
    return ubifs_jnl_write_inode(c, inode);
    }

    - ubifs_delete_orphan(c, inode->i_ino);
    err = ubifs_tnc_remove_ino(c, inode->i_ino);
    if (err)
    ubifs_ro_mode(c, err);
    + else
    + ubifs_delete_orphan(c, inode->i_ino);
    up_read(&c->commit_sem);
    return err;
    }
    --
    1.5.4.1


    \
     
     \ /
      Last update: 2008-08-13 10:47    [W:0.019 / U:0.012 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site