lkml.org 
[lkml]   [2008]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] UBIFS: do not write orphans back
    Date
    From: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>

    Orphan inodes are deleted inodes which will disappear after FS
    re-mount. There is not need to write orphan inodes back, because
    they are not needed on the flash media.

    So optimize orphans a little by not writing them back. Just mark
    them as clean, free the budget, and report success to VFS.

    Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@nokia.com>
    ---
    fs/ubifs/super.c | 18 +++++++++++++-----
    1 files changed, 13 insertions(+), 5 deletions(-)

    diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
    index 884beed..13e90b0 100644
    --- a/fs/ubifs/super.c
    +++ b/fs/ubifs/super.c
    @@ -278,7 +278,7 @@ static void ubifs_destroy_inode(struct inode *inode)
    */
    static int ubifs_write_inode(struct inode *inode, int wait)
    {
    - int err;
    + int err = 0;
    struct ubifs_info *c = inode->i_sb->s_fs_info;
    struct ubifs_inode *ui = ubifs_inode(inode);

    @@ -299,10 +299,18 @@ static int ubifs_write_inode(struct inode *inode, int wait)
    return 0;
    }

    - dbg_gen("inode %lu, mode %#x", inode->i_ino, (int)inode->i_mode);
    - err = ubifs_jnl_write_inode(c, inode, 0);
    - if (err)
    - ubifs_err("can't write inode %lu, error %d", inode->i_ino, err);
    + /*
    + * As an optimization, do not write orphan inodes to the media just
    + * because this is not needed.
    + */
    + dbg_gen("inode %lu, mode %#x, nlink %u",
    + inode->i_ino, (int)inode->i_mode, inode->i_nlink);
    + if (inode->i_nlink) {
    + err = ubifs_jnl_write_inode(c, inode, 0);
    + if (err)
    + ubifs_err("can't write inode %lu, error %d",
    + inode->i_ino, err);
    + }

    ui->dirty = 0;
    mutex_unlock(&ui->ui_mutex);
    --
    1.5.4.1


    \
     
     \ /
      Last update: 2008-08-13 10:45    [W:0.025 / U:0.484 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site