Messages in this thread | | | Date | Wed, 13 Aug 2008 11:15:36 +0200 | From | Ingo Molnar <> | Subject | Re: [patch]fastboot: remove duplicate unpack_to_rootfs() |
| |
* Frans Meulenbroeks <fransmeulenbroeks@gmail.com> wrote:
> 2008/8/13, Ingo Molnar <mingo@elte.hu>: > > > > * Ingo Molnar <mingo@elte.hu> wrote: > > > > > the dry_run variable is now unused in unpack_to_rootfs() and could be > > > eliminated. > > > > also, while we are materially touching init/initramfs.c, that file has > > collected a few uglies in the past few years, checkpatch --file says: > > > > total: 7 errors, 7 warnings, 3 checks, 562 lines checked > > > > it has a few other problems as well that can be seen if you look at the > > file. Unused macros: > > > > /* Diagnostic functions (stubbed out) */ > > #define Assert(cond,msg) > > #define Trace(x) > > #define Tracev(x) > > #define Tracevv(x) > > #define Tracec(c,x) > > #define Tracecv(c,x) > > > > #define STATIC static > > #define INIT __init > > > These are not really unused. A few lines later it reads: > > #include "../src/inflate.c" > > These macros are used within inflate.c
oh, i _knew_ i saw this zlib ugliness sometime in the past.
> (and perhaps the inclusion of inflate.c is not a good idea, maybe this > should be in lib.a note that inflate.c is also included in > init/do_mounts_rd.c; fortunately this is all init code (which is > probably why include was used in the first place))
definitely. It's a different patch though.
Ingo
| |