lkml.org 
[lkml]   [2008]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 01/01][retry 1] x86: L3 cache index disable for 2.6.26
    On Tue, Aug 12, 2008 at 05:01:46PM -0500, Langsdorf, Mark wrote:
    > > > + for (i = 0; i < 2; i++) {
    > > > + unsigned int reg = 0;
    > > > +
    > > > + pci_read_config_dword(dev, 0x1BC + i * 4, &reg);
    > > > +
    > > > + ret += sprintf(buf, "%s %x\t", buf, reg);
    > > > + }
    > > > + ret += sprintf(buf,"%s\n", buf);
    > >
    > > So you print "buf" few times? Why? And you use both \t and \n
    > > as deliminer...
    >
    > I'm printing the values of the two config registers into
    > the string buffer, separated by tabs, and terminated by
    > an EOL. Is there a prefered way to do that instead of
    > what I have?

    Yes, two different files, one for each config register.

    thanks,

    greg k-h


    \
     
     \ /
      Last update: 2008-08-13 00:59    [W:0.020 / U:126.800 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site