lkml.org 
[lkml]   [2008]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] cpuset: Rework sched domains and CPU hotplug handling (take 4)
Rakib Mullick wrote:
> One more thing Max, while you are allocating memory for "dattr" I
> think it needs to check that it is successful or not . I've shown it
> on one of my previous patch on 7th Aug.

I think you missed this part of the patch

> + /*
> + * The rest of the code, including the scheduler, can deal with
> + * dattr==NULL case. No need to abort if alloc fails.
> + */
> dattr = kmalloc(ndoms * sizeof(struct sched_domain_attr), GFP_KERNEL);

I replied to your patch saying that we do not need to check it. And Paul
suggested to add a comment to explain why.

Max




\
 
 \ /
  Last update: 2008-08-12 05:31    [W:0.071 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site