Messages in this thread | | | Date | Mon, 11 Aug 2008 20:27:43 -0700 | From | Max Krasnyansky <> | Subject | Re: [PATCH] cpuset: Rework sched domains and CPU hotplug handling (take 4) |
| |
Rakib Mullick wrote: > One more thing Max, while you are allocating memory for "dattr" I > think it needs to check that it is successful or not . I've shown it > on one of my previous patch on 7th Aug.
I think you missed this part of the patch
> + /* > + * The rest of the code, including the scheduler, can deal with > + * dattr==NULL case. No need to abort if alloc fails. > + */ > dattr = kmalloc(ndoms * sizeof(struct sched_domain_attr), GFP_KERNEL);
I replied to your patch saying that we do not need to check it. And Paul suggested to add a comment to explain why.
Max
| |