lkml.org 
[lkml]   [2008]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: Kernel oops with 2.6.26, padlock and ipsec: probably problem with fpu state changes

    * Suresh Siddha <suresh.b.siddha@intel.com> wrote:

    > Reported-and-bisected-by: Wolfgang Walter <wolfgang.walter@stwm.de>
    > Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>

    no fundamental objection to the x86 bits.

    shouldnt this:

    + if (!in_interrupt())
    + return 0;

    just be eliminated and the cr0/TS save/restore be made unconditional?
    irq-assymetric APIs are not nice in general.

    Reading/setting cr0 isnt _that_ slow. (or if it is, by how much does it
    slow things down, exactly?)

    Ingo


    \
     
     \ /
      Last update: 2008-08-11 21:25    [W:4.605 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site