lkml.org 
[lkml]   [2008]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86_64: remove empty lines from stack traces/oopses

* Alexey Dobriyan <adobriyan@gmail.com> wrote:

> show_trace_log_lvl(struct task_struct *task, struct pt_regs *regs,
> unsigned long *stack, unsigned long bp, char *log_lvl)
> {
> - printk("\nCall Trace:\n");
> + printk("Call Trace:\n");
> dump_trace(task, regs, stack, bp, &print_trace_ops, log_lvl);
> - printk("\n");
> }

hm, it's nice to have stack traces stand out a bit, and to not get the
'Call Trace' embedded in the middle of a printk (which happens to crash
or produce a stack dump).

> void show_trace(struct task_struct *task, struct pt_regs *regs,
> @@ -386,6 +385,7 @@ show_stack_log_lvl(struct task_struct *task, struct pt_regs *regs,
> printk(" %016lx", *stack++);
> touch_nmi_watchdog();
> }
> + printk("\n");
> show_trace_log_lvl(task, regs, sp, bp, log_lvl);
> }
>
> @@ -443,7 +443,6 @@ void show_registers(struct pt_regs *regs)
> printk("Stack: ");
> show_stack_log_lvl(NULL, regs, (unsigned long *)sp,
> regs->bp, "");
> - printk("\n");
>
> printk(KERN_EMERG "Code: ");

just to make sure i get the gist of your change, do you have a 'before'
and 'after' sample oops, so that we can see the difference?

Ingo


\
 
 \ /
  Last update: 2008-08-11 19:05    [W:0.283 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site