lkml.org 
[lkml]   [2008]   [Aug]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sky2: Fix suspend/hibernation/shutdown regression with WOL enabled
On Sat, 9 Aug 2008 23:32:28 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:

> sky2: Fix suspend/hibernation/shutdown regression with WOL enabled
>
> On my test box with the Asus M3A32-MVP main board there is a
> regression from 2.6.26 related to suspend, hibernation and
> shutdown. Namely, if Wake-on-LAN is enabled with
> 'ethtool -s eth0 wol g', the box hangs solid during all of these
> operations, while executing either sky2_suspend(), or
> sky2_shutdown(). This patch fixes it for me.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> drivers/net/sky2.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> Index: linux-2.6/drivers/net/sky2.c
> ===================================================================
> --- linux-2.6.orig/drivers/net/sky2.c
> +++ linux-2.6/drivers/net/sky2.c
> @@ -665,7 +665,8 @@ static void sky2_phy_power_down(struct s
> GM_GPCR_FL_PASS | GM_GPCR_SPEED_100 | GM_GPCR_AU_ALL_DIS);
>
> if (hw->chip_id != CHIP_ID_YUKON_EC) {
> - if (hw->chip_id == CHIP_ID_YUKON_EC_U) {
> + if (hw->chip_id == CHIP_ID_YUKON_EC_U
> + && hw->chip_rev != CHIP_REV_YU_EC_U_B0) {
> ctrl = gm_phy_read(hw, port, PHY_MARV_PHY_CTRL);
>
> /* enable Power Down */

The problem is not unique to your chip version, so patching out
the power down is not the correct solution.


\
 
 \ /
  Last update: 2008-08-10 08:59    [W:0.050 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site