lkml.org 
[lkml]   [2008]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] power: support for Texas Instruments BQ27x00 battery managers.
On Fri, Aug 01, 2008 at 12:28:53PM +0400, Anton Vorontsov wrote:
> > On Mon, Jun 23, 2008 at 10:38:17AM +0400, Anton Vorontsov wrote:
> >
> > > Here is the patch to show the idea. I only tested it to build, so no
> > > guaranties that it will work on the actual hardware. :-)
> > >
> > > This patch should be separated: one patch is for I2C subsystem
> > > maintainer (drivers/i2c/* changes) and another (drivers/power/* +
> > > include/linux/bq27x00.h) is for me.
> >
> > On my system I need to specify 2 battery chips into the platform
> > specific file as follow (file is arch/arm/mach-pxa/wr1100.c):
> >
> > static struct i2c_board_info __initdata wr1100_i2c_mux_devices[] = {
> > {
> > I2C_BOARD_INFO("bq27200", 0x55),
> > },
> > };
> >
> > i2c_register_board_info(2, wr1100_i2c_mux_devices,
> > ARRAY_SIZE(wr1100_i2c_mux_devices));
> > i2c_register_board_info(3, wr1100_i2c_mux_devices,
> > ARRAY_SIZE(wr1100_i2c_mux_devices));
> >
> > By using your solution I cannot use this code, is that right?
>
> Why not? I think there should be no problem.

The platform_driver_register() conflicts with i2c_add_driver(),
doesn't it? O_o

> [...]
> > if you agree, I prefere resend my
> > patch without the #ifdef and the w1 support (since I cannot test it at
> > all) but living the possibility to add that support later.
>
> Yes, that would be also fine.

Ok, since I cannot test the w1 subsystem at all, is better I provide
only tested code. :)

Ciao,

Rodolfo

--

GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti


\
 
 \ /
  Last update: 2008-08-01 11:29    [W:0.205 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site