Messages in this thread | | | Date | Fri, 1 Aug 2008 14:11:23 -0700 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH 1/2] rcu: just rename call_rcu_bh instead of making it a macro |
| |
On Wed, Jul 30, 2008 at 02:20:54PM -0400, Steven Rostedt wrote: > Seems that I found a box that has a config that passes call_rcu_bh as a > function pointer (see net/sctp/sm_make_chunk.c), so declaring the > call_rcu_bh has a macro function isn't good enough. > > This patch makes it just another name of call_rcu for rcupreempt.
Looks good!
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Steven Rostedt <srostedt@redhat.org> > > --- > include/linux/rcupreempt.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > Index: linux-compile.git/include/linux/rcupreempt.h > =================================================================== > --- linux-compile.git.orig/include/linux/rcupreempt.h 2008-07-30 13:56:28.000000000 -0400 > +++ linux-compile.git/include/linux/rcupreempt.h 2008-07-30 13:57:57.000000000 -0400 > @@ -57,7 +57,13 @@ static inline void rcu_qsctr_inc(int cpu > rdssp->sched_qs++; > } > #define rcu_bh_qsctr_inc(cpu) > -#define call_rcu_bh(head, rcu) call_rcu(head, rcu) > + > +/* > + * Someone might want to pass call_rcu_bh as a function pointer. > + * So this needs to just be a rename and not a macro function. > + * (no parentheses) > + */ > +#define call_rcu_bh call_rcu > > /** > * call_rcu_sched - Queue RCU callback for invocation after sched grace period. > > --
| |