lkml.org 
[lkml]   [2008]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: linux-next: Tree for July 30
On Fri, Aug 01, 2008 at 12:12:19PM -0700, Linus Torvalds wrote:
>
> Ok, I apparently missed this whole subthread yesterday, only getting back
> to it when going over my old queues.
>
> On Thu, 31 Jul 2008, Dmitry Torokhov wrote:
> >
> > Input: paper over a bug in Synaptics X driver
>
> Yeah, it's not pretty, but how about moving that EV_KEY thing into the
> switch() statement?

I want to to be visually separated. It is not a hot path so extra
comparison won't hurt us.

> Also, the printk could certainly be a bit more useful.

I think I will follow Andrew's advice and point people to a page on
kernel.org (to be written).

> have that four-deep indentation by just splitting that horrible function
> up a bit.
>
> IOW, start off with a patch like the appended,

Makes sense. Signed-off-by please ;)

--
Dmitry


\
 
 \ /
  Last update: 2008-08-01 21:27    [W:0.071 / U:1.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site