Messages in this thread Patch in this message | | | Date | Wed, 30 Jul 2008 19:50:23 +0400 | From | Cyrill Gorcunov <> | Subject | [PATCH -tip] x86: apic - use SET_APIC_DEST_FIELD macro |
| |
Use predefined macro instead of hardcoded bit shifting
Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> ---
I'm on really sloooow gprs connection so fetching replies not that often and if there is some inconvenience with this patch i'll not answer fast, sorry.
Index: linux-2.6.git/arch/x86/kernel/apic_64.c =================================================================== --- linux-2.6.git.orig/arch/x86/kernel/apic_64.c 2008-07-24 23:16:04.000000000 +0400 +++ linux-2.6.git/arch/x86/kernel/apic_64.c 2008-07-24 23:20:56.000000000 +0400 @@ -150,7 +150,7 @@ u32 safe_xapic_wait_icr_idle(void) void xapic_icr_write(u32 low, u32 id) { - apic_write(APIC_ICR2, id << 24); + apic_write(APIC_ICR2, SET_APIC_DEST_FIELD(id)); apic_write(APIC_ICR, low); }
| |