Messages in this thread | | | Date | Wed, 9 Jul 2008 15:11:21 +0400 | From | Dmitry <> | Subject | Re: [patch 2/4] MFD: Coding style fixes |
| |
2008/7/9 Ben Dooks <ben-linux@fluff.org>: > Fix some coding style fixes in the mfd core driver. > > Signed-off-by: Ben Dooks <ben-linux@fluff.org>
I don't have a strong feeling about this. As it's pretty much only whitespace changes, my feelings are closer to NAK. Leaving decision to Samuel or Ian.
> > Index: linux-2.6.26-rc9-next20080709/drivers/mfd/mfd-core.c > =================================================================== > --- linux-2.6.26-rc9-next20080709.orig/drivers/mfd/mfd-core.c 2008-07-09 10:43:54.000000000 +0100 > +++ linux-2.6.26-rc9-next20080709/drivers/mfd/mfd-core.c 2008-07-09 10:44:45.000000000 +0100 > @@ -16,9 +16,9 @@ > #include <linux/mfd/core.h> > > static int mfd_add_device(struct platform_device *parent, > - const struct mfd_cell *cell, > - struct resource *mem_base, > - int irq_base) > + const struct mfd_cell *cell, > + struct resource *mem_base, > + int irq_base) > { > struct resource res[cell->num_resources]; > struct platform_device *pdev; > @@ -75,11 +75,10 @@ fail_alloc: > return ret; > } > > -int mfd_add_devices( > - struct platform_device *parent, > - const struct mfd_cell *cells, int n_devs, > - struct resource *mem_base, > - int irq_base) > +int mfd_add_devices(struct platform_device *parent, > + const struct mfd_cell *cells, int n_devs, > + struct resource *mem_base, > + int irq_base) > { > int i; > int ret = 0; > Index: linux-2.6.26-rc9-next20080709/include/linux/mfd/core.h > =================================================================== > --- linux-2.6.26-rc9-next20080709.orig/include/linux/mfd/core.h 2008-07-09 10:43:54.000000000 +0100 > +++ linux-2.6.26-rc9-next20080709/include/linux/mfd/core.h 2008-07-09 10:44:45.000000000 +0100 > @@ -1,5 +1,3 @@ > -#ifndef MFD_CORE_H > -#define MFD_CORE_H > /* > * drivers/mfd/mfd-core.h > * > @@ -13,6 +11,9 @@ > * > */ > > +#ifndef MFD_CORE_H > +#define MFD_CORE_H > + > #include <linux/platform_device.h> > > /* > @@ -38,17 +39,15 @@ struct mfd_cell { > const struct resource *resources; > }; > > -static inline struct mfd_cell * > -mfd_get_cell(struct platform_device *pdev) > +static inline struct mfd_cell *mfd_get_cell(struct platform_device *pdev) > { > return (struct mfd_cell *)pdev->dev.platform_data; > } > > -extern int mfd_add_devices( > - struct platform_device *parent, > - const struct mfd_cell *cells, int n_devs, > - struct resource *mem_base, > - int irq_base); > +extern int mfd_add_devices(struct platform_device *parent, > + const struct mfd_cell *cells, int n_devs, > + struct resource *mem_base, > + int irq_base); > > extern void mfd_remove_devices(struct platform_device *parent); > > > -- >
-- With best wishes Dmitry
| |