Messages in this thread | | | Date | Wed, 09 Jul 2008 13:17:25 -0700 | From | Jeremy Fitzhardinge <> | Subject | Re: [patch] power, xen64: fix PM_SLEEP build dependencies |
| |
Ingo Molnar wrote: > * Rafael J. Wysocki <rjw@sisk.pl> wrote: > > >>> This combination actually doesn't make sense whatsoever. >>> >>> PM_SLEEP depends (indirectly) on PM and the fact that it's possible >>> to use a .config violating this dependency is a build system >>> problem, really. >>> >> Your patch is correct, though. :-) >> > > yes, that combination doesnt make sense in -git, but tip/xen64 tries the > !PM && PM_SLEEP combination - see the patch below. What do you think > about that patch? > > I think Jeremy's patch makes sense, but no strong feelings. We can > certainly map out these side-effects. (the fixes you've been Cc:-ed to > should be roughly all that can happen i think.) >
I found the PM dependencies a bit confusing. Xen save/restore/migrate is functionally equivalent to some mixture HIBERNATE and SUSPEND (saving an image to disk is HIBERNATE, but live migration is more like SUSPEND). Its implementation needs to be able to get the device model to do the right things - specifically the system timer devices - but has no other dependency on the rest of the PM infrastructure.
J
| |