lkml.org 
[lkml]   [2008]   [Jul]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [patch] power, xen64: fix PM_SLEEP build dependencies (was: Re: [PATCH 00 of 55] xen64: implement 64-bit Xen support)
    Date
    On Wednesday, 9 of July 2008, Ingo Molnar wrote:
    >
    > * Rafael J. Wysocki <rjw@sisk.pl> wrote:
    >
    > > > This combination actually doesn't make sense whatsoever.
    > > >
    > > > PM_SLEEP depends (indirectly) on PM and the fact that it's possible
    > > > to use a .config violating this dependency is a build system
    > > > problem, really.
    > >
    > > Your patch is correct, though. :-)
    >
    > yes, that combination doesnt make sense in -git, but tip/xen64 tries the
    > !PM && PM_SLEEP combination - see the patch below.

    It shouldn't. There are many things compiled if PM is set that PM_SLEEP
    depends on, most importantly ->suspend() and ->resume() callbacks of almost
    all drivers. Ignoring this dependency is asking for trouble.

    > What do you think about that patch?
    >
    > I think Jeremy's patch makes sense, but no strong feelings. We can
    > certainly map out these side-effects. (the fixes you've been Cc:-ed to
    > should be roughly all that can happen i think.)

    > ------------------->
    > commit 6fbbec428c8e7bb617da2e8a589af2e97bcf3bc4
    > Author: Jeremy Fitzhardinge <jeremy@goop.org>
    > Date: Tue Jul 8 15:07:08 2008 -0700
    >
    > suspend, xen: enable PM_SLEEP for CONFIG_XEN
    >
    > Xen save/restore requires PM_SLEEP to be set without requiring
    > SUSPEND or HIBERNATION.
    >
    > Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
    > Cc: Stephen Tweedie <sct@redhat.com>
    > Cc: Eduardo Habkost <ehabkost@redhat.com>
    > Cc: Mark McLoughlin <markmc@redhat.com>
    > Signed-off-by: Ingo Molnar <mingo@elte.hu>
    >
    > diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
    > index b45da40..1436c47 100644
    > --- a/kernel/power/Kconfig
    > +++ b/kernel/power/Kconfig
    > @@ -82,7 +82,7 @@ config PM_SLEEP_SMP
    >
    > config PM_SLEEP
    > bool
    > - depends on SUSPEND || HIBERNATION
    > + depends on SUSPEND || HIBERNATION || XEN
    > default y
    >
    > config SUSPEND

    I don't like this.

    I'll have a look at the remaining related patches and see what can be done.

    Jeremy, what exactly do you need the !PM && PM_SLEEP combination for, BTW?

    Rafael


    \
     
     \ /
      Last update: 2008-07-09 22:19    [W:4.088 / U:0.060 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site