Messages in this thread | | | Date | Wed, 9 Jul 2008 11:59:12 -0700 | From | "Yinghai Lu" <> | Subject | Re: [patch] tip/x86_64: fix e820 merge issue which broke max_pfn_mapped |
| |
On Wed, Jul 9, 2008 at 11:48 AM, Suresh Siddha <suresh.b.siddha@intel.com> wrote: > On Wed, Jul 09, 2008 at 11:05:46AM -0700, Yinghai Lu wrote: >> > BTW, please explain the need for your patch which has more changes, instead >> > of my simple patch which was test booted on 3 different systems with both >> > 32bit and 64bit kernels... >> >> try to reduce #ifdef CONFIG_X86_64/32, and make 32/64 at the same page. > > But it seem to have too many changes included in one patch. > > like calls to e820_register_active_regions(), remove_all_active_ranges() > disappeared all together in this patch.. ??
old e820_end_of_ram() need to active_ranges aka early_node_map is initialized... so if we make e820_end to get end of any type, we don't need to call e820_register_active_regions anymore. and just letnuma code init that later. to avoid extra operation.
should put more words in commit desc.
YH
| |