Messages in this thread | | | Date | Wed, 9 Jul 2008 16:49:29 +0100 | From | Alan Cox <> | Subject | Re: [PATCH] Mark i2o config broken on 64-bit platforms. |
| |
On Wed, 09 Jul 2008 15:15:14 +0100 David Howells <dhowells@redhat.com> wrote:
> Miquel van Smoorenburg <miquels@cistron.nl> wrote: > Maybe, but have you looked at i2o_cfg_passthru()? Take this, for example: > > /* Allocate memory for the transfer */ > p = kmalloc(sg_size, GFP_KERNEL); > ... > //TODO 64bit fix > sg[i].addr_bus = virt_to_bus(p); > > That looks distinctly dodgy. virt_to_bus() returns a 64-bit address, and as
Agreed - stick | GFP_DMA32 on the end then ;)
Alan
| |