Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH 2/3] stop_machine: simplify | Date | Wed, 9 Jul 2008 12:18:56 +1000 |
| |
On Wednesday 09 July 2008 01:02:02 Akinobu Mita wrote: > 2008/7/8 Rusty Russell <rusty@rustcorp.com.au>: > > On Tuesday 08 July 2008 21:44:40 Akinobu Mita wrote: > >> I found a small possible cleanup in this patch. > > > > Well spotted! I think this cleanup is actually orthogonal to my patch, > > so best served as a separate patch, how's this? > > Actually the cpu_online() check was necessary before appling this > stop_machine: simplify patch. > > With old __stop_machine_run(), __stop_machine_run() could succeed > (return !IS_ERR(p) value) even if take_cpu_down() returned non-zero value. > The return value of take_cpu_down() was obtained through kthread_stop().
Ah, thanks for the analysis!
It's a little non-obvious, so I've left it as a separate patch (it doesn't hurt to have the check there), but included your excellent explanation within it.
Thanks! Rusty.
| |