lkml.org 
[lkml]   [2008]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject[PATCH] CONFIG_KMOD needs to be default y
From
Date
Far too many people configure their kernel without CONFIG_KMOD
and then complain that wireless breaks, thanks to Herbert Xu for
pointing me to this.

This patch makes CONFIG_KMOD default to "y" and adds a warning
that people should not turn it off.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Rusty Russell <rusty@rustcorp.com.au>
---
Maybe it should even depend on EMBEDDED? Who needs this option off
in the first place?

init/Kconfig | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

--- everything.orig/init/Kconfig 2008-07-08 13:42:10.000000000 +0200
+++ everything/init/Kconfig 2008-07-08 13:43:41.000000000 +0200
@@ -895,6 +895,7 @@ config MODULE_SRCVERSION_ALL
config KMOD
bool "Automatic kernel module loading"
depends on MODULES
+ default y
help
Normally when you have selected some parts of the kernel to
be created as kernel modules, you must load them (using the
@@ -902,7 +903,12 @@ config KMOD
here, some parts of the kernel will be able to load modules
automatically: when a part of the kernel needs a module, it
runs modprobe with the appropriate arguments, thereby
- loading the module if it is available. If unsure, say Y.
+ loading the module if it is available.
+
+ Do not say N unless you know you do not need it, and expect
+ wireless, crypto and other things to break in this case.
+
+ Say Y.

config STOP_MACHINE
bool



\
 
 \ /
  Last update: 2008-07-08 13:53    [W:0.038 / U:0.468 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site