lkml.org 
[lkml]   [2008]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] UIO: Change driver name of uio_pdrv
Hi Hans,

Hans J. Koch wrote:
> I'm just about to use the generic UIO platform device driver in a
> project. I noticed the driver registers itself simply as "uio". We
> should choose a more unique name here. The oneliner below goes on top of
> the other UIO patches you've got in your queue right now. This is not in
> mainline yet.
I don't care much, but IMHO "uio" is fine, because the name has a
context (i.e. it's the name of a platform device) and so adding "_pdrv"
doesn't yield a more clear result.

I don't claim to know all or even many platform drivers, the ones I
currently use (and that are in mainline, too) are:

gpio-keys
i2c-gpio
leds-gpio
physmap-flash
serial8250

and for all of these I consider it right not to have a "pdrv" suffix.

> The generic UIO platform device driver should be given a unique driver ID and
> not just "uio". This is especially important since Magnus Damm announced a
> similar driver named uio_pdrv_genirq. We should get the names right before
> this hits mainline.
So using uio_genirq here would be the logical consequence.

But as I said, I don't care much and both options are fine for me.

Best regards
Uwe

--
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2008-07-08 12:51    [W:0.020 / U:3.368 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site