lkml.org 
[lkml]   [2008]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -mm 1/2] kexec jump -v12: kexec jump
From
Date
Hi, Pavel,

On Mon, 2008-07-07 at 20:50 +0800, Pavel Machek wrote:
> Hi!
>
> The patch looks mostly ok to me. (Perhaps there's time to split it
> into smaller chunks?)
>
> You can add Acked-by: Pavel Machek <pavel@suse.cz> to it, I guess.

Thank you very much!

[...]
> > @@ -98,16 +101,24 @@ int machine_kexec_prepare(struct kimage
> > */
> > void machine_kexec_cleanup(struct kimage *image)
> > {
> > + if (nx_enabled)
> > + set_pages_nx(image->control_code_page, 1);
> > }
>
> , 0 ? (setup and cleanup were same, which is strange).

Oh, Yes. That should be 0, I will change it.
>
> > @@ -1411,3 +1421,50 @@ static int __init crash_save_vmcoreinfo_
> > }
> >
> > module_init(crash_save_vmcoreinfo_init)
> > +
> > +/**
> > + * kernel_kexec - reboot the system

> Really?

I will change the comments to reflect the changes to kernel_kexec.

> > + * Move into place and start executing a preloaded standalone
> > + * executable. If nothing was preloaded return an error.
> > + */
> > +int kernel_kexec(void)
> > +{
> > + int error = 0;
> > +
> > + if (xchg(&kexec_lock, 1))
> > + return -EBUSY;
>
> That's quite a strange way to provide a lock. mutex_trylock?

I think this is because kexec_lock is used by crash_kexec() too, which
may be called in some extreme environment, such as during panic().

> > + if (!kexec_image) {
> > + error = -EINVAL;
> > + goto Unlock;
> > + }
> > +
> > + if (kexec_image->preserve_context) {
> > +#ifdef CONFIG_KEXEC_JUMP
> > + local_irq_disable();
> > + save_processor_state();
>
> #else
> BUG()
>
> ...because otherwise you silently do nothing?
>
> > +#endif
>
> Pavel

If CONFIG_KEXEC_JUMP is defined, kexec_image->preserve_context will
always be 0. So current code is safe. Here, #ifdef is used to resolve
the dependency issue. For example, save_processor_state() may be
undefined if CONFIG_KEXEC_JUMP is not defined.

Best Regards,
Huang Ying




\
 
 \ /
  Last update: 2008-07-08 11:07    [W:0.082 / U:1.316 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site