lkml.org 
[lkml]   [2008]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [Patch 06/10] mfd: PCAP driver for the Motorola EZX GSM mobile phones

    > o Eric, what do you like the PCAP_REDIRECT_IRQ flag to do?
    >

    I'm seeing the following the block of code in the original patch:

    +/* PCAP */
    +static int ezx_pcap_init(void)
    +{

    ...

    + /* redirect all interrupts to AP */
    + if (!(machine_is_ezx_a780() || machine_is_ezx_e680()))
    + ezx_pcap_write(PCAP_REG_INT_SEL, 0);
    +
    + return 0;
    +}

    that prevent this driver from being generic, a flag of PCAP_REDIRECT_IRQ
    might be used to decide the writing to PCAP_REG_INT_SEL is necessary.



    \
     
     \ /
      Last update: 2008-07-09 04:37    [W:8.748 / U:0.232 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site