lkml.org 
[lkml]   [2008]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: [PATCH] padlock: don't whinge when loaded on a non-VIA cpu
From
Date
On Tue, 2008-07-08 at 15:37 -0400, Kyle McMartin wrote:
> diff --git a/drivers/crypto/padlock-sha.c b/drivers/crypto/padlock-sha.c
> index c666b4e..70ec14b 100644
> --- a/drivers/crypto/padlock-sha.c
> +++ b/drivers/crypto/padlock-sha.c
> @@ -253,6 +253,10 @@ static int __init padlock_init(void)
> {
> int rc = -ENODEV;
>
> + if (!((boot_cpu_data.x86_vendor == X86_VENDOR_CENTAUR) &&
> + (boot_cpu_data.x86 >= 6))) /* only on VIA C3 and above */
> + return -ENODEV;
> +
> if (!cpu_has_phe) {
> printk(KERN_ERR PFX "VIA PadLock Hash Engine not detected.\n");
> return -ENODEV;

int rc doesn't need to be initialized to -ENODEV either.

diff --git a/drivers/crypto/padlock-sha.c b/drivers/crypto/padlock-sha.c
--- a/drivers/crypto/padlock-sha.c
+++ b/drivers/crypto/padlock-sha.c
@@ -251,7 +251,7 @@ static struct crypto_alg sha256_alg = {

static int __init padlock_init(void)
{
- int rc = -ENODEV;
+ int rc;

if (!cpu_has_phe) {
printk(KERN_ERR PFX "VIA PadLock Hash Engine not detected.\n");



\
 
 \ /
  Last update: 2008-07-08 23:25    [W:0.033 / U:22.132 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site