lkml.org 
[lkml]   [2008]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC 06/11] remove CONFIG_KMOD from fs
On Tue, Jul 08, 2008 at 07:00:21PM +0200, Johannes Berg wrote:
>...
> --- everything.orig/fs/nls/nls_base.c 2008-07-08 18:32:40.000000000 +0200
> +++ everything/fs/nls/nls_base.c 2008-07-08 18:34:44.000000000 +0200
>...
> @@ -216,15 +214,13 @@ static struct nls_table *find_nls(char *
> struct nls_table *load_nls(char *charset)
> {
> struct nls_table *nls;
> -#ifdef CONFIG_KMOD
> int ret;
> -#endif

That gives an "unused variable" gcc warning with CONFIG_MODULES=n.

> nls = find_nls(charset);
> if (nls)
> return nls;
>
> -#ifdef CONFIG_KMOD
> +#ifdef CONFIG_MODULES
> ret = request_module("nls_%s", charset);
> if (ret != 0) {
> printk("Unable to load NLS charset %s\n", charset);
>

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed



\
 
 \ /
  Last update: 2008-07-08 22:01    [from the cache]
©2003-2011 Jasper Spaans