lkml.org 
[lkml]   [2008]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[patch 9/17] Use WARN() in arch/x86/mm/ioremap.c
From: Arjan van de Ven <arjan@linux.intel.com>
Subject: Use WARN instead of printk+WARN_ON in arch/x86/mm/ioremap.c

Use WARN() instead of a printk+WARN_ON() pair; this way the message
becomes part of the warning section for better reporting/collection.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Acked-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/mm/ioremap.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

Index: linux.trees.git/arch/x86/mm/ioremap.c
===================================================================
--- linux.trees.git.orig/arch/x86/mm/ioremap.c
+++ linux.trees.git/arch/x86/mm/ioremap.c
@@ -522,13 +522,11 @@ static int __init check_early_ioremap_le
{
if (!early_ioremap_nested)
return 0;
-
- printk(KERN_WARNING
+ WARN(1, KERN_WARNING
"Debug warning: early ioremap leak of %d areas detected.\n",
- early_ioremap_nested);
+ early_ioremap_nested);
printk(KERN_WARNING
- "please boot with early_ioremap_debug and report the dmesg.\n");
- WARN_ON(1);
+ "please boot with early_ioremap_debug and report the dmesg.\n");

return 1;
}

\
 
 \ /
  Last update: 2008-07-08 19:03    [W:0.111 / U:1.984 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site