Messages in this thread | | | Date | Tue, 8 Jul 2008 20:56:00 +0400 | From | "Alexander Beregalov" <> | Subject | Re: [PATCH] drm_memory.h: remove double inclusion of linux/vmalloc.h |
| |
2008/7/8 Ian Romanick <ianr@q7.com>: > On Tue, Jul 08, 2008 at 08:29:57AM -0400, Mark Asselstine wrote: >> On Sun, Jul 6, 2008 at 7:31 AM, Alexander Beregalov >> <a.beregalov@gmail.com> wrote: >> > From: Alexander Beregalov <a.beregalov@gmail.com> >> > >> > #if __OS_HAS_AGP >> > >> > -#include <linux/vmalloc.h> >> > - >> >> Why remove this one and not the one at the top of the file? As well > > I would assume this one is removed because it is inside additional > ifdefs. Yes, it does not change functionality of the code. > >> this file has #include of drmP.h, yet drmP.h is the only file I can >> find that includes drm_memory.h. Based on this I would think there is >> some additional cleanup that can go on here. How it can be cleaned up? Do you mean to move `define PAGE_AGP` to drmP.h?
| |